Allow excerpt to override integrated requests #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow_excerpt_html() currently exits early when called within an AJAX request. This replaces the simple is_admin() check with your more comprehensive (and filterable) is_integrated_request() function
JakePT
approved these changes
Aug 25, 2022
rebeccahum
added a commit
to Automattic/ElasticPress
that referenced
this pull request
Nov 9, 2022
rebeccahum
added a commit
to Automattic/ElasticPress
that referenced
this pull request
Nov 9, 2022
rebeccahum
added a commit
to Automattic/ElasticPress
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
allow_excerpt_html()currently exits early when called within an AJAX or other integrated request. This replaces the simple is_admin() check with your more comprehensive (and filterable)is_integrated_request()function. The same mechanism is used inadd_search_highlight_tags(), which is the only place that this function is called from.How to test the Change
Try to do a search that includes highlighting from within an AJAX context before and after this change.
Changelog Entry
Credits
Props @nickchomey
Checklist: